From 8c810f22765ccd0be9995e0dc57db48657887cdb Mon Sep 17 00:00:00 2001
From: mheyse <github@mheyse.de>
Date: Thu, 4 Jul 2024 09:00:12 +0200
Subject: [PATCH] fix nullptr linter error

---
 src/modbus.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/modbus.cpp b/src/modbus.cpp
index ba1423903..df4f2541e 100644
--- a/src/modbus.cpp
+++ b/src/modbus.cpp
@@ -65,8 +65,10 @@ bool Modbus::check_parameter_order() {
     for (const auto & mi : modbus_register_mappings) {
         if (isFirst) {
             isFirst = false;
-        } else if (prev == nullptr || !prev->isLessThan(mi)) {
-            // TODO fix nullptr dereference when printing
+        } else if (prev == nullptr) {
+            LOG_ERROR("Error checking modbus parameters %s.", mi.short_name);
+            return false;
+        } else if(!prev->isLessThan(mi)) {
             LOG_ERROR("Error in modbus parameters: %s must be listed before %s.", mi.short_name, prev->short_name);
             return false;
         }