Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update igraph and fix build #589

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update igraph and fix build #589

wants to merge 6 commits into from
+16 −14

Conversation

xiota
Copy link

@xiota xiota commented Sep 15, 2024

Fixes problems preventing build on Arch Linux. Closes #588

@harnhua
Copy link

harnhua commented Sep 18, 2024

Thank you for these updates.
I was able to apply these to the current published branch and build successfully on an M1 Mac.

@RenWal
Copy link
Contributor

RenWal commented Oct 14, 2024

Thanks for the contribution!

We may want to reconsider the choice for which plugins to build by default; your proposed change in 98a8e06 would cause the build to include the entire simulator toolchain by default, which comes with a bunch of dependency concerns. See my comment here: #588 (comment)

@SJulianS: any reservations against bumping igraph to 0.10.13?

@szhorvat
Copy link

Consider bumping to 0.10.15.

@xiota
Copy link
Author

xiota commented Nov 11, 2024 •
edited
Loading

This PR no longer cleanly applies to HEAD. Was previously planning to rebase, but decided not to because emsec developers did not respond to the issue report or this PR.

With current latest commit (f715873), cherry-picking the following commits from this PR should allow successful build with vendored igraph (0.10.12). System igraph doesn't work, but won't try to figure out why.

  • f67c717 - Add missing algorithm header
  • c3d3b81 - Cast Z3_decl_kind to std::size_t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonKlx SimonKlx Awaiting requested review from SimonKlx SimonKlx is a code owner

@nils1603 nils1603 Awaiting requested review from nils1603 nils1603 is a code owner

@SJulianS SJulianS Awaiting requested review from SJulianS SJulianS is a code owner

@joern274 joern274 Awaiting requested review from joern274 joern274 is a code owner

@swallat swallat Awaiting requested review from swallat swallat is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to build on Arch Linux
4 participants
@xiota @harnhua @RenWal @szhorvat