Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node configuration potentially breaking builds #1242

Closed
jeswr opened this issue Jun 26, 2023 · 1 comment
Closed

Node configuration potentially breaking builds #1242

jeswr opened this issue Jun 26, 2023 · 1 comment

Comments

@jeswr
Copy link

jeswr commented Jun 26, 2023

In swipl-wasm we have this dockerfile extending the emsdk docker image to build the code for our package.

We upgraded to emsdk v3.1.42 without any problems. As a follow up I tried to remove our manual override setting the node version to node 16; as theoretically this is the default in emsdk v3.1.42. However this broke our build with the error wasm-ld: error: src/libswipl.a(pl-alloc.c.o): undefined symbol: PL_dlsym.

Pull request attempting to remove node 16 override: SWI-Prolog/npm-swipl-wasm#246.
Build failure: https://github.com/SWI-Prolog/npm-swipl-wasm/actions/runs/5368721408/jobs/9739613650?pr=246

Any ideas on what could be causing this?

@jeswr
Copy link
Author

jeswr commented Jun 26, 2023

Ignore - I forgot to remove the DNODE_JS_EXECUTABLE parameter.

@jeswr jeswr closed this as completed Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant