Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix can not start new pod error #984

Merged
merged 1 commit into from
Jan 4, 2024
Merged

fix: fix can not start new pod error #984

merged 1 commit into from
Jan 4, 2024

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Jan 4, 2024

cancel sync EMQX config from EMQX API

fix #983

cancel sync EMQX config from EMQX API

fix #983

Signed-off-by: Rory Z <[email protected]>
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (fa4d0b0) 77.87% compared to head (52ae7b8) 78.08%.
Report is 1 commits behind head on main.

❗ Current head 52ae7b8 differs from pull request most recent head 9332473. Consider uploading reports for the commit 9332473 to get more accurate results

Files Patch % Lines
controllers/apps/v2beta1/sync_emqx_config.go 77.77% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #984      +/-   ##
==========================================
+ Coverage   77.87%   78.08%   +0.21%     
==========================================
  Files          67       67              
  Lines        6088     6060      -28     
==========================================
- Hits         4741     4732       -9     
+ Misses       1125     1108      -17     
+ Partials      222      220       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z merged commit f90a18a into emqx:main Jan 4, 2024
36 checks passed
@Rory-Z Rory-Z deleted the fix/fix-config-error branch January 4, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom acl.conf created via Dashboard is not propageted to new nodes
1 participant