Feat: Migrate query suggestions module to composition api
#1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le-to-composition-api # Conflicts: # packages/_vue3-migration-test/src/router.ts
victorcg88
reviewed
May 31, 2024
...s/_vue3-migration-test/src/x-modules/query-suggestions/components/test-query-suggestions.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/query-suggestions/components/query-suggestion.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/query-suggestions/components/query-suggestions.vue
Outdated
Show resolved
Hide resolved
…le-to-composition-api # Conflicts: # packages/_vue3-migration-test/src/router.ts
…le-to-composition-api # Conflicts: # packages/_vue3-migration-test/src/router.ts
victorcg88
previously approved these changes
Jun 7, 2024
| @@ -16,7 +16,7 @@ | |||
| "@vueuse/core": "~10.7.1", | |||
| "vue": "^3.4.22", | |||
| "vue-router": "^4.3.0", | |||
| "vuex": "^4.1.0" | |||
| "vuex": "4.0.2" | |||
There was a problem hiding this comment.
Reactivity of vuex getters is broken in 4.1.0 when registering store modules dynamically. vuejs/vuex#2217
vuejs/vuex#2197
It caused emitters didn't work when the trigger is a getter and not the state (request getter of QuerySuggestions x-module).
Downgraded to 4.0.2
diegopf
approved these changes
Jun 12, 2024
diegopf
deleted the
feat/EMP-4163-migrate-query-suggestions-module-to-composition-api
branch
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.
Motivation and context
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Tests performed according to testing guidelines:
Checklist: