Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Update for C++20 #194

Open
gconeice opened this issue Oct 18, 2024 · 2 comments
Open

Potential Update for C++20 #194

gconeice opened this issue Oct 18, 2024 · 2 comments

Comments

@gconeice
Copy link
Contributor

gconeice commented Oct 18, 2024

Hi,

I noticed that the file emp-tool/emp-tool/utils/ThreadPool.h is still using std::result_of, which has been discarded in C++20. This can be simply fixed by using std::invoke_result instead.

I can make a pull request if needed.

Thanks!

@gconeice
Copy link
Contributor Author

Note that you may also need macros to switch between C++ <= 14 and C++ > 14.

@wangxiao1254
Copy link
Member

That would be appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants