build shared library, allow system install #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also has some overlap with Issue #123. |
|
I don't see point of adding this option. |
janisozaur
reviewed
Mar 13, 2018
| @@ -82,3 +89,5 @@ if (RC_ENABLE_EXAMPLES) | |||
| endif() | |||
|
|
|||
| add_subdirectory(extras) | |||
|
|
|||
| install(TARGETS rapidcheck DESTINATION /usr/lib) | |||
|
For installing you may want to use |
Ah, I didn't know that. Thanks. |
|
@mhwombat Is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will
Address Issue cmake install option? #182 by allowing the user to install the library.
Allow the user to create a shared library instead of a static library as follows:
cmake -DRC_SHARED_LIBRARY=ON .
You may prefer some other way of doing this, so feel free to reject this pull request.