Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make parameter and objective classes slotted #74

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Make parameter and objective classes slotted #74

wants to merge 3 commits into from
+17 −21

Conversation

AdrianSosic
Copy link
Collaborator

@AdrianSosic AdrianSosic commented Jan 4, 2024 •
edited
Loading

Now that attrs==24.1.0 supports cached_property with slotted classes, we can finally enable slots for our parameter and objective classes.

@AdrianSosic AdrianSosic self-assigned this Jan 4, 2024
@AdrianSosic AdrianSosic added the enhancement Expand / change existing functionality label Jan 4, 2024
@AdrianSosic
Copy link
Collaborator Author

Note: there was another issue which messed with our subclass detection mechanism, which has already be resolved but the fix has not yet been released. However, the checks should automatically pass once attrs 24.1.0 is available.

AVHopp
AVHopp approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@AVHopp AVHopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there is not really a need for a proper and full review, this is just some maintenance right?

Scienfitz
Scienfitz reviewed Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@Scienfitz Scienfitz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

@Scienfitz Scienfitz added the on hold PR progress is awaiting for something else to continue label Apr 3, 2024
@AdrianSosic AdrianSosic mentioned this pull request Apr 11, 2024
Merged
@AdrianSosic
Copy link
Collaborator Author

@AVHopp @Scienfitz, FYI: I rebased and added one more commit since in the meantime we also had to make our Objective classes slotted ... a change that can be similarly reverted by this PR once the attrs support has been released

@AdrianSosic AdrianSosic changed the title Make parameter classes slotted Make parameter and objective classes slotted Apr 18, 2024
@Scienfitz Scienfitz marked this pull request as draft June 21, 2024 14:30
@AdrianSosic AdrianSosic removed the on hold PR progress is awaiting for something else to continue label Aug 3, 2024
@AdrianSosic AdrianSosic marked this pull request as ready for review August 3, 2024 19:44
AVHopp
AVHopp reviewed Aug 13, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@AdrianSosic
Copy link
Collaborator Author

Again on hold until the following blocking issue gets resolved:
python-attrs/attrs#1325

@AdrianSosic AdrianSosic added the on hold PR progress is awaiting for something else to continue label Aug 13, 2024
@AdrianSosic AdrianSosic marked this pull request as draft August 13, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AVHopp AVHopp AVHopp approved these changes

@Scienfitz Scienfitz Scienfitz approved these changes

Assignees

@AdrianSosic AdrianSosic

Labels
enhancement Expand / change existing functionality on hold PR progress is awaiting for something else to continue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrianSosic @Scienfitz @AVHopp