Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #22 #23

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix #22 #23

wants to merge 5 commits into from

Conversation

michaelontiveros
Copy link

I made MakeStringWithLen non-static, and changed the type of the first variable from char to const char.
I replaced MarkBag with GAP_MarkBag from libgap.
I passed dummy variables to OpenOutputStream and CloseOutput.

@michaelontiveros michaelontiveros changed the title fix embray/gappy#22 fix #22 May 1, 2024
Copy link
Owner

@embray embray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the fixes. Iirc this also fixed a second issue that I think has been requested to specify the heap size.

I guess it will break with older GAP versions but that is maybe not so important as GAP users don't tend to linger on old versions for so long.

I'll need to update the CI at some point and also bump the supported CPython versions but LGTM otherwise.

gappy/core.pyx Outdated Show resolved Hide resolved
return CloseOutput(&output);
}
"""
UInt GAP_OpenOutputStream(Obj stream)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a string? Is this a Cython trick I forgot?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry which string?

This reverts commit cacb42b.
@michaelontiveros
Copy link
Author

michaelontiveros commented May 4, 2024

oh shoot i just reverted the #18 memory fix because the tests failed! Would you like me to put it back?
i put it back lol :)

specify gap's heap size in the gap initializer like

gap = Gap( gap_root, gap_memory )

where gap_memory is the integer valued heap size in megabytes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants