You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am trying to have an Ember app embedded into a 3rd party page, and to coexist peacefully with its JS assets, including those based an AMD modules, that use incompatible implementations of define() and require() than those that Ember/loader.js defines (globally!).
Using either the approach to call loader.noConflict() (see ember-cli/loader.js#204) at the end of app.js or using transforms like https://github.com/richardaiko/ember-derequire fail due to this addon patching (and later reverting) the global require()here. In the case of using noConflict(), what happens is that noConflict() reverts correctly, but this addon reverts it overwritten require()afterwards, but again with Ember's version. So the globally defined one remain that of Ember/loader.js, which breaks other 3rd party scripts relying on the original AMD version.
Not sure how best to fix this universally. FWIW, I ended up removing @classic due to this...
The text was updated successfully, but these errors were encountered:
I am trying to have an Ember app embedded into a 3rd party page, and to coexist peacefully with its JS assets, including those based an AMD modules, that use incompatible implementations of
define()
andrequire()
than those that Ember/loader.js defines (globally!).Using either the approach to call
loader.noConflict()
(see ember-cli/loader.js#204) at the end of app.js or using transforms like https://github.com/richardaiko/ember-derequire fail due to this addon patching (and later reverting) the globalrequire()
here. In the case of usingnoConflict()
, what happens is thatnoConflict()
reverts correctly, but this addon reverts it overwrittenrequire()
afterwards, but again with Ember's version. So the globally defined one remain that of Ember/loader.js, which breaks other 3rd party scripts relying on the original AMD version.Not sure how best to fix this universally. FWIW, I ended up removing
@classic
due to this...The text was updated successfully, but these errors were encountered: