Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Polaris mascots #1119

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Adds Polaris mascots #1119

merged 4 commits into from
Jul 16, 2024

Conversation

MelSumner
Copy link
Member

If merged, this PR adds the Polaris Tomster and Zoey to the website.

CleanShot 2024-07-15 at 16 34 03@2x

@MelSumner MelSumner requested review from a team July 15, 2024 21:35
Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit dc66290
🔍 Latest deploy log https://app.netlify.com/sites/ember-website/deploys/66959ea541e4190009310cc5
😎 Deploy Preview https://deploy-preview-1119--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jul 15, 2024

1/14 Files got Bigger 🚨:

Details
File raw gzip
ember-website-fastboot.js +306 B +58 B

13/14 Files stayed the same size 🤷‍:

Details
File raw gzip
blurhash.js 0 B 0 B
chunk.143.js 0 B 0 B
chunk.177.js 0 B 0 B
chunk.178.js 0 B -1 B
chunk.208.js 0 B 0 B
chunk.488.js 0 B 0 B
ember-website.js 0 B +1 B
polyfill-evergreen.js 0 B 0 B
polyfill-legacy.js 0 B 0 B
polyfill-shared.js 0 B 0 B
vendor.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B -1 B

Created by ember-asset-size-action

@MelSumner
Copy link
Member Author

One of the things I am not sure about is that tests are failing for things I did not change. Is this a known issue?

@mansona
Copy link
Member

mansona commented Jul 16, 2024

@MelSumner yes we opted to remove some of the strange mocking implementations of data for the tests because they stopped reflecting reality and we missed a few bugs. Essentially it's a bit more annoying to update the website but it's much safer to make any changes now 👍

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MelSumner MelSumner merged commit e948ba8 into main Jul 16, 2024
7 checks passed
@MelSumner MelSumner deleted the melsumner/add-polaris-mascots branch July 16, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants