Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: extend the Polaris edition page #1069

Merged
merged 8 commits into from
Jan 22, 2024

Conversation

IgnaceMaes
Copy link
Member

@IgnaceMaes IgnaceMaes commented Oct 28, 2023

Document the core concepts in some more detail and link to relevant information sources.

Preview:
https://deploy-preview-1069--ember-website.netlify.app/editions/polaris/

@netlify
Copy link

netlify bot commented Oct 28, 2023

Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit c50fe9f
🔍 Latest deploy log https://app.netlify.com/sites/ember-website/deploys/65aea08bf6edfc0008f5b394
😎 Deploy Preview https://deploy-preview-1069--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for filling this in! I’ve left some suggestions for clarifying the concepts and approach. If I’m way off, please let me know. I’ve been away on leave and I’m not fully in the loop about Polaris.

Any learning team member may merge this and override my review. Let’s get this in soon!

app/templates/editions/polaris.hbs Outdated Show resolved Hide resolved
app/templates/editions/polaris.hbs Outdated Show resolved Hide resolved
app/templates/editions/polaris.hbs Outdated Show resolved Hide resolved
app/templates/editions/polaris.hbs Outdated Show resolved Hide resolved
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@mansona mansona merged commit b46b116 into ember-learn:main Jan 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants