Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polaris editions page #1058

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Add Polaris editions page #1058

merged 5 commits into from
Sep 12, 2023

Conversation

locks
Copy link
Contributor

@locks locks commented Sep 8, 2023

No description provided.

@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit 9e5845c
🔍 Latest deploy log https://app.netlify.com/sites/ember-website/deploys/64ffa7b75cfc1b0008acaafb
😎 Deploy Preview https://deploy-preview-1058--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

1/14 Files got Bigger 🚨:

Details
File raw gzip
ember-website.js +3.22 kB +543 B

13/14 Files stayed the same size 🤷‍:

Details
File raw gzip
blurhash.js 0 B 0 B
chunk.143.js -2 B -2 B
chunk.177.js 0 B 0 B
chunk.178.js -4 B -2 B
chunk.208.js 0 B 0 B
chunk.488.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
polyfill-evergreen.js 0 B 0 B
polyfill-legacy.js 0 B 0 B
polyfill-shared.js 0 B 0 B
vendor.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B +1 B

Created by ember-asset-size-action

Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Just some minor comments. I would say ship it!

app/templates/editions/polaris.hbs Outdated Show resolved Hide resolved
app/templates/editions/polaris.hbs Outdated Show resolved Hide resolved
Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the strategy of getting this out ASAP once there is an image. Thank you!

@MinThaMie
Copy link
Contributor

Discussed during the learning meeting to use the blueprint Tomster until we have a real image :)

@locks locks marked this pull request as ready for review September 11, 2023 23:47
@locks locks merged commit 1da1dee into main Sep 12, 2023
4 checks passed
@locks locks deleted the editions-polaris branch September 12, 2023 14:32
@clionaderoiste
Copy link

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants