Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embroider Initiative Sponsors #1034

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Embroider Initiative Sponsors #1034

merged 2 commits into from
Jul 10, 2023

Conversation

mansona
Copy link
Member

@mansona mansona commented Jun 8, 2023

This needs to be a) finished and b) validated before merging

@netlify
Copy link

netlify bot commented Jun 8, 2023 •
edited
Loading

✅ Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit 5d77aef
🔍 Latest deploy log https://app.netlify.com/sites/ember-website/deploys/64ab3a90640a760008950b9b
😎 Deploy Preview https://deploy-preview-1034--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jun 8, 2023 •
edited
Loading

1/14 Files got Bigger 🚨:

Details
File raw gzip
ember-website.js +3.05 kB +304 B

13/14 Files stayed the same size 🤷‍:

Details
File raw gzip
blurhash.js 0 B 0 B
chunk.143.js +4 B +3 B
chunk.177.js 0 B 0 B
chunk.178.js 0 B -2 B
chunk.208.js 0 B 0 B
chunk.488.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
polyfill-evergreen.js 0 B 0 B
polyfill-legacy.js 0 B 0 B
polyfill-shared.js 0 B 0 B
vendor.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B +4 B

Created by ember-asset-size-action

@mansona mansona force-pushed the initiative branch 4 times, most recently from 8509e56 to b888931 Compare June 8, 2023 16:09
@mansona mansona force-pushed the initiative branch 3 times, most recently from 9796619 to c1d9116 Compare June 28, 2023 10:42
@mansona mansona requested a review from wifelette June 28, 2023 11:51
@mansona mansona marked this pull request as ready for review June 29, 2023 08:41
@mansona mansona changed the title WIP Initiative Initiative Sponsors Jun 29, 2023
@mansona mansona changed the title Initiative Sponsors Embroider Initiative Sponsors Jun 29, 2023
wifelette
wifelette requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@wifelette wifelette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! It's missing a period after "Read more about the Embroider Initiative and see all the contributors here" but otherwise, ship it!

@mansona mansona merged commit fb51490 into main Jul 10, 2023
@mansona mansona deleted the initiative branch July 10, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wifelette wifelette wifelette requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mansona @wifelette