Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer this.import instead of app.import #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brendenpalmer
Copy link

this allows using loader.js as a nested dependency; import internally uses _findHost and calls import on this: https://github.com/ember-cli/ember-cli/blob/master/lib/models/addon.js#L784

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably need to try this.import and fallback to app.import.

I'm specifically worried about mega old ember-cli versions that don't have this.import, but folks are using the current major version of loader.js without issue.

@brendenpalmer brendenpalmer changed the title use this.import instead of app.import prefer this.import instead of app.import Jul 1, 2021
@machty
Copy link

machty commented Mar 22, 2022

This is biting me because I'm extracting an ember-engine from an app and currently have loader.js specified as an engine dependency... is "loader.js" considered a dependency of an engine? If not, why not?

@TikiTDO
Copy link

TikiTDO commented May 20, 2022

@rwjblue Any chance this could get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants