Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolver does not honor the loader noconflict aliases #629

Open
rajasegar opened this issue Dec 28, 2020 · 1 comment · May be fixed by #634
Open

Resolver does not honor the loader noconflict aliases #629

rajasegar opened this issue Dec 28, 2020 · 1 comment · May be fixed by #634

Comments

@rajasegar
Copy link

If we use the loader.noConflict method from the loader.js, with the following aliases,

loader.noConflict({
require: 'myRequire'
})

the app fails with an error

Uncaught TypeError: Cannot read property 'entries' of undefined
    at new ModuleRegistry (vendor.js:formatted:68415)

because there is no global require object, we only have myRequire now

Related to ember-cli/loader.js#139

@rwjblue
Copy link
Member

rwjblue commented Jan 15, 2021

Definitely possible to fix, would love a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants