Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try cp-property-map codemod from ember-3x-codemods #727

Merged
merged 3 commits into from
Oct 23, 2019

Conversation

rajasegar
Copy link
Contributor

@@ -11,6 +11,10 @@ export default Controller.extend({
return `${this.firstName} ${this.lastName}`;
},

friendNames: map('friends', ['nameKey'], function(friend) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you import map? Just in case the codemod starts following the source in the future, and not codemodding things that don't come from ember.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, similarly for the computed properties also we need to import the computed right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, but I wouldn't worry about it for this pull request

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then, I will make changes for importing map

@kellyselden kellyselden merged commit 6d79ffd into ember-cli:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants