Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Clarify the choose-blueprint-updates step #1109

Open
ijlee2 opened this issue Mar 2, 2021 · 5 comments
Open

[suggestion] Clarify the choose-blueprint-updates step #1109

ijlee2 opened this issue Mar 2, 2021 · 5 comments

Comments

@ijlee2
Copy link

ijlee2 commented Mar 2, 2021

Description

Hello. I was helping out a couple of people on Discord.

They weren't sure what to do when they encountered the following prompt in an initial step of the ember-cli-update wizard.

Initial step of choose blueprint updates

I think this happened due to a couple of factors:

  • A user didn't want to upgrade to the latest version (3.25), but to some prior version as a stepping stone (3.16, in the example above).
  • The prompt doesn't specify what key to press to continue (the prompt only mentions arrow keys).

Suggested solution

I looked at https://github.com/ember-cli/ember-cli-update/blob/master/src/choose-blueprint-updates.js to see how the blueprint update options were created.

I think we could either:

  • Update the prompt to clarify that the user can set the target update version in the next step (I didn't check if there is such next step)
  • Update the prompt to confirm the user's desired target version (e.g. read from --to value).
  • Update the blueprint update options to hide latest, or include the user's --to value
  • Look into another solution

Can you let us know what you think about this suggestion? Thanks!

@sly7-7
Copy link

sly7-7 commented Mar 2, 2021

I was a bit confused as well by this prompt. I would go for Update the blueprint update options to hide latest, or include the user's --to value

@kellyselden
Copy link
Member

I think the docs need to be updated. --to is being phased out. This is because there can be multiple blueprints being tracked in ember-cli-update.json. Because of this, reusing --to might not work based on which blueprint you pick.

@sly7-7
Copy link

sly7-7 commented Mar 4, 2021

@kellyselden Thanks for the feedback. So you're suggesting to remove the --to example from the readme ?
That mean that running ember-cli-update will then prompt the user to choose the targeted version ?

@kellyselden
Copy link
Member

Correct. The workflow is you first pick a blueprint (most commonly only a single one), then you pick what will become the --to.

Now that I think of it, maybe if there's only a single blueprint and they've supplied a --to, we can skip the blueprint prompt?

@sly7-7
Copy link

sly7-7 commented Mar 4, 2021

It could be a good move.
Though, I've just tested without --to and it already works as this I think.
Screenshot from 2021-03-04 19-52-25
Not related to this issue, bu if possible, I think this could be a very good thing to suggest the available versions if choosing semver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants