Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--live-reload-* command line options need documentation #53

Open
Redsandro opened this issue Sep 22, 2018 · 2 comments
Open

--live-reload-* command line options need documentation #53

Redsandro opened this issue Sep 22, 2018 · 2 comments

Comments

@Redsandro
Copy link

Redsandro commented Sep 22, 2018

I am trying to change my live-reload-host to localhost because my http port is proxied to a development url. It's unclear to find out how to do this.

$ ./node_modules/.bin/ember help | grep reload
  --live-reload (Boolean) (Default: true)
  --live-reload-host (String) Defaults to host
  --live-reload-base-url (String) Defaults to baseURL
  --live-reload-port (Number) (Defaults to port number within [49152...65535])

Needs documentation.

  • --live-reload-host changes the websocket host
  • --live-reload-base-url changes the javascript location relative to baseURL
  • --live-reload-port doesn't seem to work in my setup overridden by .ember-cli

I can't seem to change the javascript location. It's always {{rootURL}}/{{baseUrl}}/livereload.js. But I need to change the rootURL for the livereload location only.


ember-cli: 3.3.0
http_parser: 2.8.0
node: 8.12.0
v8: 6.2.414.66
uv: 1.19.2
zlib: 1.2.11
ares: 1.10.1-DEV
modules: 57
nghttp2: 1.32.0
napi: 3
openssl: 1.0.2p
icu: 60.1
unicode: 10.0
cldr: 32.0
tz: 2017c
os: linux x64
npm: 6.4.1
@Redsandro
Copy link
Author

I was specifying the options wrong. The documentation is not entirely clear. Now that I specified host, the host doesn't change. livereload.js is still requested from the same domain as the domain. What is this option for anyway?

@Redsandro
Copy link
Author

Redsandro commented Sep 23, 2018

What is this option for anyway?

Ah, it seems to change the hostname for the connection to the websocket that is opened. And then livereload doesn't work anymore, because from a security context, the websocket needs to be on the same hostname. So both hostnames would have to change; the one where the livereload.js is loaded from, and the one where the websocket is connecting to.

@Redsandro Redsandro changed the title live-reload command line arguments not working live-reload-port command line argument not working Sep 24, 2018
@Redsandro Redsandro changed the title live-reload-port command line argument not working --live-reload-* command line options need documentation Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant