Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI flag for --live-reload-js-url #150

Open
sandstrom opened this issue Sep 9, 2020 · 4 comments
Open

Add CLI flag for --live-reload-js-url #150

sandstrom opened this issue Sep 9, 2020 · 4 comments

Comments

@sandstrom
Copy link

sandstrom commented Sep 9, 2020

The config value liveReloadJsUrl can be set via .ember-cli but not as a command-line flag (--live-reload-js-url).

This is different from the four config values that can be set using either the config file or CLI flags (see photo).


FOR REFERENCE (photo from repo readme: https://github.com/ember-cli/ember-cli-inject-live-reload)

image

END REFERENCE


Would you be open to making liveReloadJsUrl configurable via a CLI flag? If so, is there any place in addition to the following file that needs to be modified?

https://github.com/ember-cli/ember-cli/blob/073c32eff73c58eee62d6327b50f4422f0cd01cc/lib/commands/serve.js#L62

cc @rwjblue @kellyselden happy to hear your thoughts about this

@rwjblue
Copy link
Member

rwjblue commented Oct 14, 2020

@chancancode - Would this resolve the issue that you and @NullVoxPopuli were discussing RE: codesandbox the other day?

@lifeart
Copy link

lifeart commented Jan 14, 2021

@rwjblue we spend some time with gitpod integration, and looks like this option help us to not owerride .ember-cli

https://github.com/Brain-up/brn/pull/1388/files#diff-822a5719a359362df7fb6ffb57759d8c5507d206ceed8e4dd01444ac9dda7201R9

@navels
Copy link

navels commented Oct 12, 2021

Bump. Any chance of getting this to the finish line? Thanks!

@sandstrom
Copy link
Author

sandstrom commented Oct 13, 2021

@navels It's almost finished actually 😄

@lifeart done an awesome work on this and fixtures (a related problem on the test side).

AFAIK it's pending a final review right now:
ember-cli/ember-cli#9430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants