Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replacement of renamed/aliased imports (e.g. import { assert as somethingElse } from '@ember/debug') #82

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link

Initial Report: emberjs/ember-cli-babel#372

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good thanks for working on it!

Could you also add usage (of both assert and deprecate) over to this test fixutre as well:

https://github.com/ember-cli/babel-plugin-debug-macros/blob/master/fixtures/ember-cli-babel-config/sample.js

That fixture runs in the ember-cli-babel style configuration, so its a good one to ensure things still work.

@rwjblue rwjblue changed the title Renamed imports are not transpiled correctly Fix replacement of renamed/aliased imports (e.g. import { assert as somethingElse } from '@ember/debug') Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants