-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow shutdown of underlying Socket #36
Comments
Yes to both, I think. I haven't heard anything from Tim, but I guess we can move forward with the shutdown |
So you mean opening a PR for custom fork (or maybe even just bundling it) and the init abuse? :D |
I mean let's implement the termination mechanism, as introduced in elmish v4 and the dependency on your fork seems ok to me. We don't include or reference JS dependencies, so it's just a matter of documenting it for the next major release, at least until the entire elmish stack is on Femto. |
@matthid the |
Description
We use the debugger in the integration-test suite (to test various stuff) and in order to make it work properly we need to shutdown the underlying socket.
To do this we need:
destroy
function.While technically this requires elmish/elmish#162
We have implemented it by "abusing" the
init
function in the following way: Ifinit
is called with a parameter ofnull
we assume this is a program shutdown, which is good enough for our testing scenario.This issue is a remainder and a starting point for discussion.
Is there interest in bringing these changes to this repository, maybe even depending on my fork of
remotedev
?I spoke about this issue in the past here and here
The text was updated successfully, but these errors were encountered: