Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align indentation where cabal check warns about it #2319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

philderbeast
Copy link

Fixes the warning about inconsistent indentation in the package.

$ cabal check
...
Warning: elm.cabal:42:5: Inconsistent indentation. Indentation jumps at lines
42
...

Found when adding elm-compiler as an Updo example. I noticed the warning there:

$ cabal build all --enable-tests --enable-benchmarks
Warning: Unknown/unsupported 'ghc' version detected (Cabal 3.11.0.0 supports
'ghc' version < 9.8): /home/philderbeast/.ghcup/bin/ghc is version 9.8.1
Resolving dependencies...
Build profile: -w ghc-9.8.1 -O1
In order, the following will be built (use -v for more details):
 - elm-0.19.1 (exe:elm) (first run)
Warning: elm.cabal:42:5: Inconsistent indentation. Indentation jumps at lines
42
Configuring executable 'elm' for elm-0.19.1...
...

Copy link

Thanks for suggesting these code changes. To set expectations:

  • Pull requests are reviewed in batches, so it can take some time to get a response.
  • Smaller pull requests are easier to review. To fix nine typos, nine specific issues will always go faster than one big one. Learn why here.
  • Reviewers may not know as much as you about certain situations, so add links to supporting evidence for important claims, especially regarding standards for CSS, HTTP, URI, etc.

Finally, please be patient with the core team. They are trying their best with limited resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant