Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use model state #375

Merged
merged 9 commits into from
Jul 30, 2024
Merged

Use model state #375

merged 9 commits into from
Jul 30, 2024

Conversation

seanmor5
Copy link
Contributor

Resolves #372

@jonatanklosko
Copy link
Member

jonatanklosko commented May 31, 2024

@seanmor5 model_state = Axon.trace_init(model, input_template) this still warns because it expects the struct, should there be a function to build the struct from the map perhaps?

(we capture logs in most tests, so it doesn't show up there)

@seanmor5
Copy link
Contributor Author

@jonatanklosko I updated trace_init to use Axon.ModelState.empty, and then pretty much everywhere in Axon we now use the Axon.ModelState.new to avoid warnings

@seanmor5 seanmor5 merged commit b2781bc into main Jul 30, 2024
2 checks passed
@seanmor5 seanmor5 deleted the use-axon-model-state branch July 30, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using bumblebee from git is broken
2 participants