Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gemma fixes #362

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Gemma fixes #362

merged 2 commits into from
Mar 12, 2024

Conversation

jonatanklosko
Copy link
Member

jonatanklosko
jonatanklosko commented Mar 12, 2024
View reviewed changes
lib/bumblebee/layers.ex
normalized_input * (opts[:shift] + weight)
end

defnp rms_norm_impl_upcast_all(input, weight, opts \\ []) do
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I was adding conditionals on the options, but I think it's cleaner to just have two separate versions altogether.

@jonatanklosko jonatanklosko merged commit 93b5580 into main Mar 12, 2024
2 checks passed
@jonatanklosko jonatanklosko deleted the jk-gemma branch March 12, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonatanklosko @josevalim