Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate optional outputs to use global layer options #360

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

jonatanklosko
Copy link
Member

Moves :output_hidden_states and :output_attentions from spec attributes to global layer options (elixir-nx/axon#563).

This fixes contrastive search to respect the model, which is currently ignores because we recreate the model.

@jonatanklosko jonatanklosko merged commit b9b73f8 into main Mar 6, 2024
2 checks passed
@jonatanklosko jonatanklosko deleted the jk-contrastive-search-precision branch March 6, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants