Group cache files by repository #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Feb 13, 2024
| defp repository_id_to_cache_scope(repository_id) do | ||
| repository_id | ||
| |> String.replace("/", "--") | ||
| |> String.replace(~r/[^\w-]/, "") |
There was a problem hiding this comment.
Maybe we can Base.url_encode64 it instead?
There was a problem hiding this comment.
The idea is exactly to keep it readable, so we end up with subdirs like facebook--convnext-tiny-224 :)
josevalim
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our cache directory has flat structure, where for each cached file we have one
.jsonfile with metadata and another with file contents. The file names are URL hashes or etags, so they are not meaningful to the user.The cache should be opaque to the user, however it's easy to accumulate a lot of models, but clearing the whole cache is not ideal, since the user may want to remove only the models they no longer plan to use. For this purpose, this PR groups all cache files related to a specific HF repository in a separate subdirectory with meaningful name.
As a result, the existing caches will be invalidated, but I think it's worth it and we can just mention in the changelog that users should clear the cache.