Add :migration_cast_version_column option #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Jun 25, 2023
lib/ecto/migration.ex
Outdated
| default, Ecto casts this column as an `int` when reading or writing to the database | ||
| when running migrations. This behavior is there for legacy reasons, but if you | ||
| want to disable the `CAST`ing, you can set this option to `false`. You might want | ||
| to do that if you are using a database that doesn't support `CAST`ing in all queries. |
There was a problem hiding this comment.
I think we can default to false and those on old databases can enable it again?
There was a problem hiding this comment.
Oh, I remember now. Rails uses strings, we always used integer, and this was added for compatibility. Yeah, we can make this behaviour opt-in.
There was a problem hiding this comment.
@josevalim awesome, nice! I've pushed changes to do that.
v0idpwn
approved these changes
Jun 26, 2023
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @josevalim on Slack, this option allows us to skip the
CAST(version AS int)that we do in migrations. Some databases, such as Cassandra, don't supportCASTinDELETEqueries, which migrations use when rolling back.I'm sure the test could be improved, I just got something together that worked 🙃