Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint code & non-code files #182

Merged
merged 9 commits into from
May 30, 2024
Merged

chore: lint code & non-code files #182

merged 9 commits into from
May 30, 2024

Conversation

JaeAeich
Copy link

@JaeAeich JaeAeich commented May 24, 2024

lint code and non code files

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (69e2437) to head (f8b66ab).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files           8        8           
  Lines         559      561    +2     
=======================================
+ Hits          549      551    +2     
  Misses         10       10           
Flag Coverage Δ
test_unit 98.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JaeAeich - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Hard-coded FTP password found. (link)
  • Hard-coded TESK FTP password found. (link)
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🔴 Security: 2 blocking issues
  • 🟡 Testing: 2 issues found
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@JaeAeich JaeAeich requested a review from uniqueg May 24, 2024 07:23
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

However, I would rename the PR to something like "chore: lint code & non-code files", given that the vast majority of changes are more directly related to linting, and the addition of the pre-commit config is just a way to enforce this.

Alternatively, create two PRs out of this: In the first you do the various linting changes to the files, in the second you only add the pre-commit config.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@JaeAeich JaeAeich changed the title chore: add pre-commit chore: lint code & non-code files May 24, 2024
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please resolve the conflicts.

@JaeAeich JaeAeich requested a review from uniqueg May 30, 2024 07:39
@uniqueg uniqueg merged commit c45c836 into main May 30, 2024
11 checks passed
@uniqueg uniqueg deleted the precommit branch May 30, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants