From c6e3964a346946e4ce7b3a40175335244fef2088 Mon Sep 17 00:00:00 2001 From: Javed Habib Date: Mon, 14 Oct 2024 10:48:59 +0530 Subject: [PATCH] review --- pyproject.toml | 1 + tesk/api/ga4gh/tes/controllers.py | 4 ++-- tesk/utils.py | 25 ------------------------- 3 files changed, 3 insertions(+), 27 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index ae2a83c..94af9d3 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -4,6 +4,7 @@ requires = ["poetry-core"] [tool.bandit] skips = [ + "B101", # Use of assert detected. "B321", # FTP-related functions are being called. "B402", # A FTP-related module is being imported. "B108" # Insecure usage of temp file/directory, false positive. diff --git a/tesk/api/ga4gh/tes/controllers.py b/tesk/api/ga4gh/tes/controllers.py index 0bbcbc6..b7c4aed 100644 --- a/tesk/api/ga4gh/tes/controllers.py +++ b/tesk/api/ga4gh/tes/controllers.py @@ -1,7 +1,7 @@ """Controllers for GA4GH TES API endpoints.""" import logging -from typing import Any +from typing import Mapping from foca.utils.logging import log_traffic # type: ignore from pydantic import ValidationError @@ -36,7 +36,7 @@ def CreateTask(**kwargs) -> dict: Args: **kwargs: Arbitrary keyword arguments. """ - request_body: Any = kwargs.get("body") + request_body: Mapping = kwargs.get("body", {}) try: tes_task = TesTask(**request_body) except ValidationError as e: diff --git a/tesk/utils.py b/tesk/utils.py index 3ef9e13..8d0091c 100644 --- a/tesk/utils.py +++ b/tesk/utils.py @@ -31,31 +31,6 @@ from tesk.exceptions import ConfigInvalidError, ConfigNotFoundError from tesk.k8s.constants import tesk_k8s_constants -from foca import Foca -from kubernetes.client.models import ( - V1Container, - V1DownwardAPIVolumeFile, - V1DownwardAPIVolumeSource, - V1EnvVar, - V1EnvVarSource, - V1Job, - V1JobSpec, - V1ObjectFieldSelector, - V1ObjectMeta, - V1PodSpec, - V1PodTemplateSpec, - V1SecretKeySelector, - V1Volume, - V1VolumeMount, -) - -from tesk.custom_config import ( - CustomConfig, - Taskmaster, -) -from tesk.exceptions import ConfigInvalidError -from tesk.k8s.constants import tesk_k8s_constants - def get_config_path() -> Path: """Get the configuration path.