Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add claim count to jobs #44

Open
tallysmartins opened this issue Aug 7, 2018 · 2 comments
Open

Add claim count to jobs #44

tallysmartins opened this issue Aug 7, 2018 · 2 comments

Comments

@tallysmartins
Copy link
Member

In some not well known scenarios, the docker execution fails and the runner does not update the job status correctly. This causes the job not to be marked as "finished" and it will be claimed again by the runner, resulting on a loop of executing a failing job. My suggestion is to add a claim_retries to jobs and a MAX_RETRIES so this failing jobs will not be claimed as they achieve this max.

I suggest a retries count of 2 or 3.

@PragTob
Copy link
Member

PragTob commented Aug 8, 2018

Good observation and sounds great!

@tallysmartins
Copy link
Member Author

PR open for this #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants