Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ai.elimu.model package #1684

Open
jo-elimu opened this issue Jul 7, 2024 · 6 comments
Open

Rename ai.elimu.model package #1684

jo-elimu opened this issue Jul 7, 2024 · 6 comments
Labels
good first issue Good for newcomers

Comments

@jo-elimu
Copy link
Member

jo-elimu commented Jul 7, 2024 •
edited
Loading

To avoid confusion with the model library, rename the ai.elimu.model package to ai.elimu.entity.
@jo-elimu jo-elimu added the good first issue Good for newcomers label Jul 7, 2024
@diptechexpo
Copy link

@jo-elimu I am new to open source contribution and looking into working on few good-first-issue. Can I work on this issue? If yes, kindly assign me the issue.

@VinaySatrasala
Copy link

there is no package ai.elimu.dao.model may be ai.elimu.model

@jo-elimu jo-elimu changed the title Rename ai.elimu.dao.model package Rename ai.elimu.model package Jul 7, 2024
@jo-elimu
Copy link
Member Author

jo-elimu commented Jul 7, 2024 •
edited by nya-elimu
Loading

there is no package ai.elimu.dao.model may be ai.elimu.model

@VinaySatrasala Thanks for pointing that out. Corrected the issue title and description.

@jo-elimu
Copy link
Member Author

jo-elimu commented Jul 7, 2024

@jo-elimu I am new to open source contribution and looking into working on few good-first-issue. Can I work on this issue? If yes, kindly assign me the issue.

@diptechexpo Yes, please open a pull request 🙂

diptechexpo added a commit to diptechexpo/elimuai-webapp that referenced this issue Jul 7, 2024
@diptechexpo
elimu-ai#1684 renamed package ai.elmu.model to ai.elmu.entity
3221f77
@diptechexpo diptechexpo mentioned this issue Jul 7, 2024
Closed
diptechexpo added a commit to diptechexpo/elimuai-webapp that referenced this issue Jul 8, 2024
@diptechexpo
elimu-ai#1684 addressed review comment to change hardcoded package na…
35bc4bd 
…me ai.elimu.model by dynaically pulling package name using BaseEntity class
jo-elimu added a commit that referenced this issue Jul 13, 2024
@jo-elimu
refactor(servlet): remove hardcoded package name
db4e2fc 
refs #1684
@jo-elimu jo-elimu mentioned this issue Jul 13, 2024
Merged
@harsh-791
Copy link

@jo-elimu i want to work on this issue

@jo-elimu
Copy link
Member Author

@harsh-791 Feel free to give it a try 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: #1684 Renamed package ai.elmu.model to ai.elmu.entity diptechexpo/elimuai-webapp
4 participants
@jo-elimu @diptechexpo @VinaySatrasala @harsh-791