Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transaction semantics #6

Open
nick-thompson opened this issue May 2, 2023 · 0 comments
Open

Fix transaction semantics #6

nick-thompson opened this issue May 2, 2023 · 0 comments
Assignees

Comments

@nick-thompson
Copy link
Contributor

Briefly touched on in #3, this task is to:

  • Correct the transaction logic so that in the event of a runtime error while applying an instruction set we can correctly abort
  • Ensure that on COMMIT_UPDATES we only rebuild the graph if the active roots have changed

I think that in order to handle the first bullet we'll likely have to split out the setProperty step into (1) validating the incoming property and (2) actually applying it. Perhaps in (2), the actual setProperty method should be noexcept. This way we can validate all property changes in the instruction set to identify if we can commit the transaction or abort, and then set them. Maybe coincides with a getPropTypes method and an automatic runtime type check?

@nick-thompson nick-thompson self-assigned this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant