Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate editors-non-ideal-state test to RTL #1627

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

erikian
Copy link
Member

@erikian erikian commented Aug 5, 2024

Ref: #1408.

This is easier to review one commit at a time since Github is not picking up the move across folders.

I've refactored renderNonIdealState so that we render it as JSX (<RenderNonIdealState editorMosaic={editorMosaic} />) instead of calling it as a regular function (renderNonIdealState(editorMosaic)) like we were doing.

@erikian erikian requested review from codebytere and a team as code owners August 5, 2024 02:39
@coveralls
Copy link

Coverage Status

coverage: 87.602%. remained the same
when pulling 5c8cb85 on rtl/editors-non-ideal-state
into 3228c9c on main.

@erickzhao erickzhao merged commit f6d785d into main Aug 20, 2024
10 checks passed
@erickzhao erickzhao deleted the rtl/editors-non-ideal-state branch August 20, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants