Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade @testing-library deps #1626

Merged
merged 1 commit into from
Aug 5, 2024
Merged

build: upgrade @testing-library deps #1626

merged 1 commit into from
Aug 5, 2024

Conversation

erikian
Copy link
Member

@erikian erikian commented Aug 5, 2024

Keeping up with RTL dependencies:

  • @testing-library/react can't be upgraded because v12 is the last version that supports React 16 and 17, so we're stuck with that until we can upgrade React
  • only a minor change was required for the @testing-library/jest-dom v5 -> v6 migration
  • the latest major version of @testing-library/dom just works with the current setup
  • the latest version of @testing-library/user-event is just a patch update for us

Ref: #1408

@erikian erikian requested review from codebytere and a team as code owners August 5, 2024 01:57
@coveralls
Copy link

Coverage Status

coverage: 87.602%. remained the same
when pulling 5931ffb on build/update-rtl
into 3228c9c on main.

Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good to know about @testing-library/react being blocked by the React 18 upgrade.

@dsanders11 dsanders11 merged commit 5191184 into main Aug 5, 2024
11 checks passed
@dsanders11 dsanders11 deleted the build/update-rtl branch August 5, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants