Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you push update so there was support of Webpack 5? #454

Open
creotiv opened this issue Sep 16, 2021 · 5 comments
Open

Can you push update so there was support of Webpack 5? #454

creotiv opened this issue Sep 16, 2021 · 5 comments

Comments

@creotiv
Copy link

creotiv commented Sep 16, 2021

No description provided.

@phryneas
Copy link

I have forked this and made it run with webpack 5 - you can find the fork here: https://github.com/phryneas/electron-webpack

Please note that I only did this as part of a spike to evaluate different build systems, so "running" for me does not mean that I covered every possible edge case - and depending if we use it for our product, it might get any updates & maintenance or not. But it might be a good starting point for others.

@Bartel-C8
Copy link

@phryneas How can I install your fork via yarn/npm?

@phryneas
Copy link

@Bartel-C8 I only built it locally with yalc and didn't end up switching over to webpack 5, so you'd have to build it yourself.

@Bartel-C8
Copy link

Bartel-C8 commented Jul 26, 2022

Thanks, got to install it (just now) with the help of: https://gitpkg.vercel.app/

yarn add -D 'https://gitpkg.now.sh/phryneas/electron-webpack/packages/electron-webpack?master'

EDIT: the above did not work ofc, as it is not built (as a running binary).

Why did you not switch to webpack 5? Some major issues?

@phryneas
Copy link

Ah sorry, this is the electron repo. Correct answer here is that I didn't end up electron at all, but went with tauri.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants