Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-webpack issue on --env.production parameter #448

Open
channelaffairs opened this issue Jun 22, 2021 · 1 comment
Open

electron-webpack issue on --env.production parameter #448

channelaffairs opened this issue Jun 22, 2021 · 1 comment

Comments

@channelaffairs
Copy link

channelaffairs commented Jun 22, 2021

  • Version:
    @expo/electron-adapter": "0.0.55"
    electron: "13.1.2"
    electron-builder: "22.11.7"

No electron-updater used

  • Target:
    Mac, Win and Linux (same issue)

image

When attempting to build for Mac/Win/Linux , the electron-webpack somehow does not handle the absence of the --env.production parameter that from my scripts is not even explicitly declared

image

Commenting the lines in the screenshot solves the problem and allows me to build on all platforms Below the command that I execute to start the build

build-electron: yarn build-deps && yarn electron-webpack && yarn electron-builder -mwl --dir -c.compression=store -c.mac.identity=null
The command above follows (as far as I'm aware) the guidelines provided by expo for the correct integration with electron

Thanks Guys!

@Gab1988
Copy link

Gab1988 commented Jul 27, 2021

The issue was coming from weback 4.x.x being not compatible with electron-webpack at present time...
I wish this stuff was documented guys as I'm sure the more devs will adopt web pack 4 the more this issue will occur

Anyhow for future reference use the following versions of webpack and webpack-cli:

webpack-cli: 3.3.10 webpack: 3.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants