Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed GTTS argument error 'random_voice' #2181

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

rodrigodasilv
Copy link

Description

Fixed GTTS argument error 'random_voice'. If the script is configured to use GTTS, do not use the arg 'random_voice' when running TTS.

Issue Fixes

None

Checklist:

  • [Y] I am pushing changes to the develop branch
  • [Dont know] I am using the recommended development environment
  • [Y] I have performed a self-review of my own code
  • [Y] I have commented my code, particularly in hard-to-understand areas
  • [Y] I have formatted and linted my code using python-black and pylint
  • [Y] I have cleaned up unnecessary files
  • [Y] My changes generate no new warnings
  • [Y] My changes follow the existing code-style
  • [Y] My changes are relevant to the project

Any other information (e.g how to test the changes)

Set settings.tts voice_choice to "googletranslate". Before chances the script would not run.

Copy link
Contributor

This pull request is stale as it has been open for 7 days with no activity. Remove stale label or comment, or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Nov 13, 2024
filepath=f"{self.path}/{filename}.mp3",
random_voice=settings.config["settings"]["tts"]["random_voice"],
)
if settings.config["settings"]["tts"]["voice_choice"] == "googletranslate":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this solution would be a little more generalized but for this case i'll approve

@JasonLovesDoggo JasonLovesDoggo merged commit a44f89b into elebumm:develop Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants