Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a bug in UserData #68

Open
ritow opened this issue Mar 31, 2017 · 1 comment
Open

a bug in UserData #68

ritow opened this issue Mar 31, 2017 · 1 comment

Comments

@ritow
Copy link

ritow commented Mar 31, 2017

org.elasticsearch.plugin.elasticfence.data.UserData.java

public UserData(String userName, String rawPassword, String... filters) {
setUsername(userName);
setPassword(rawPassword);
SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssZZ");
setCreated(sdf.format(new Date()));
if (filters == null) { // TODO , this should be "filters != null"
Set filterSet = Sets.newConcurrentHashSet(Arrays.asList(filters));
setFilters(filterSet);
} else {
Set filterSet = Sets.newConcurrentHashSet();
setFilters(filterSet);
}
}

@lmangani
Copy link
Collaborator

Could you extend on your report or submit a PR? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants