Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless][8.16] Notes docs #6006

Open
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Oct 27, 2024

Contributes to #5441

ESS:

Serverless: (Same changes as detailed above)

@nastasha-solomon nastasha-solomon added Feature: Alerts Feature: Timeline Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Large Issues that require significant planning, research, writing, and testing ci:doc-build v8.16.0 v8.17.0 labels Oct 27, 2024
@nastasha-solomon nastasha-solomon self-assigned this Oct 27, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elasticdocs
Copy link

elasticdocs commented Oct 27, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@nastasha-solomon nastasha-solomon marked this pull request as ready for review October 28, 2024 04:24
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner October 28, 2024 04:24
@nastasha-solomon nastasha-solomon marked this pull request as ready for review October 28, 2024 14:24
Copy link

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only taken a look at the notes so far. It looks good, I left a few comments

docs/events/add-manage-notes.asciidoc Outdated Show resolved Hide resolved
docs/events/add-manage-notes.asciidoc Outdated Show resolved Hide resolved
docs/events/add-manage-notes.asciidoc Outdated Show resolved Hide resolved
docs/events/add-manage-notes.asciidoc Outdated Show resolved Hide resolved
docs/events/add-manage-notes.asciidoc Outdated Show resolved Hide resolved
docs/events/add-manage-notes.asciidoc Show resolved Hide resolved
docs/events/add-manage-notes.asciidoc Outdated Show resolved Hide resolved
docs/events/add-manage-notes.asciidoc Outdated Show resolved Hide resolved
docs/events/add-manage-notes.asciidoc Outdated Show resolved Hide resolved
docs/events/add-manage-notes.asciidoc Outdated Show resolved Hide resolved
docs/events/add-manage-notes.asciidoc Outdated Show resolved Hide resolved
Copy link

mergify bot commented Oct 30, 2024

This pull request is now in conflicts. Could you fix it @nastasha-solomon? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-5441-the-notes-expansion upstream/issue-5441-the-notes-expansion
git merge upstream/main
git push upstream issue-5441-the-notes-expansion

PhilippeOberti
PhilippeOberti previously approved these changes Oct 30, 2024
Copy link

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks awesome, thanks for making all the changes!

There is a //Note to self text in a couple of places, I'm just highlighting it just in case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:doc-build Effort: Large Issues that require significant planning, research, writing, and testing Feature: Alerts Feature: Timeline Priority: High Issues that are time-sensitive and/or are of high customer importance v8.16.0 v8.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants