Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firehose redirects #3824

Closed
wants to merge 1 commit into from
Closed

Conversation

alaudazzi
Copy link
Contributor

Adds redirects for the Firehose pages removed with elastic/docs#2970.

Relates to #3749

@alaudazzi alaudazzi self-assigned this Apr 23, 2024
@alaudazzi alaudazzi requested a review from a team as a code owner April 23, 2024 14:37
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Apr 23, 2024

This pull request does not have a backport label. Could you fix it @alaudazzi? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Apr 23, 2024
@alaudazzi
Copy link
Contributor Author

@elastic/obs-docs a couple of questions:

  • How do we handle the redirect for the file docs/en/aws-firehose/index.asciidoc?
  • After the redirects are merged, do we need to remove the entire aws-firehose folder (asciidoc files+ images)?

@bmorelli25
Copy link
Member

@alaudazzi unfortunately this won't work. This PR adds redirects from the Observability Guide to the Observability Guide. What we need are redirects from the Amazon Kinesis Data Firehose Ingest Guide to the Observability Guide.

Redirect files only apply to the book they are included in. Because the Amazon Kinesis Data Firehose Ingest Guide was removed in elastic/docs#2970, we can't add a redirect file to it and thus can't use Asciidoctor redirects.

I expect the web team redirects to go live any day now. Here's the issue: https://github.com/elastic/website-development/issues/12832.

@bmorelli25 bmorelli25 closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants