Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging configuration example to the Configure inputs page #489

Merged
merged 12 commits into from
Jun 11, 2024

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Sep 13, 2023

This adds a logging configuration example to the standalone agent Configure inputs page.

DOCS PREVIEW

Rel: #374
Closes: #556

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Oct 5, 2023

I realized I should split this into separate PRs. That way, the list of inputs PR can be merged back into the current 8.10 docs (I've verified the list against the 8.10 and main versions of the Beats spec files). This PR won't be backported since it describes the flattened data_stream notation being added via elastic/elastic-agent#3465

@mergify
Copy link

mergify bot commented Oct 10, 2023

This pull request is now in conflict. Could you fix it @kilfoyle? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch <remote-repo>
git checkout -b 374/input-settings-v2 <remote-repo>/374/input-settings-v2
git merge <remote-repo>/main
git push <remote-repo> 374/input-settings-v2

@kilfoyle kilfoyle changed the title Update standalone input settings docs to match elastic-agent.yml Add logging configuration example to the Configure inputs page Nov 28, 2023
@kilfoyle kilfoyle requested a review from a team as a code owner November 28, 2023 16:13
karenzone
karenzone previously approved these changes Nov 28, 2023
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Nov 28, 2023

@belimawr I see that the flattened notation is merged now, so do you think it's okay to merge this docs change? Here's a preview, if don't mind taking a look.

@kilfoyle
Copy link
Contributor Author

Hi @belimawr when you have time can you please check if this example logging config looks okay?

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Jun 7, 2024

@elasticmachine run docs-build
(this should rebuild the docs preview link)

@kilfoyle
Copy link
Contributor Author

Thanks @belimawr!

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kilfoyle kilfoyle merged commit 0c56b67 into elastic:main Jun 11, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jun 11, 2024
* Update standalone input settings docs to match elastic-agent.yml

* fixup

* Move simplfied input config to input page

* Re-add separate logging page

* Add input types tables

* Add input types tables; address comments

* touchup

* Remove list of agent inputs; I'll merge them as a separate PR

* Rebuild preview page

* Re-add inputs list link

* Rebuild

(cherry picked from commit 0c56b67)
kilfoyle added a commit that referenced this pull request Jun 11, 2024
…#1124)

* Update standalone input settings docs to match elastic-agent.yml

* fixup

* Move simplfied input config to input page

* Re-add separate logging page

* Add input types tables

* Add input types tables; address comments

* touchup

* Remove list of agent inputs; I'll merge them as a separate PR

* Rebuild preview page

* Re-add inputs list link

* Rebuild

(cherry picked from commit 0c56b67)

Co-authored-by: David Kilfoyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand standalone agent input settings docs with example, list of types
3 participants