Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking link in 8.10 troubleshooting docs to known issue 3375 #475

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

kilfoyle
Copy link
Contributor

Fixes a bad link that's breaking the 8.10 Fleet & Agent Release Notes PR.

@@ -653,5 +653,5 @@ curl -u elastic:<password> --request POST \
[[php-key-download-fail]]
== Air-gapped {agent} upgrade can fail due to an inaccessible PGP key

In versions 8.9 and above, an {agent} upgrade may fail when the upgrader can't access a PGP key required to verify the binary signature. For details and a workaround, refer to the <<known-issue-3375,PGP key download fails in an air-gapped environment>> known issue in the version 8.9.0 Release Notes or to the link:https://github.com/elastic/elastic-agent/blob/main/docs/pgp-workaround.md[workaround documentation] in the elastic-agent GitHub repository.
In versions 8.9 and above, an {agent} upgrade may fail when the upgrader can't access a PGP key required to verify the binary signature. For details and a workaround, refer to the link:https://www.elastic.co/guide/en/fleet/current/release-notes-8.9.0.html#known-issue-3375[PGP key download fails in an air-gapped environment] known issue in the version 8.9.0 Release Notes or to the link:https://github.com/elastic/elastic-agent/blob/main/docs/pgp-workaround.md[workaround documentation] in the elastic-agent GitHub repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit

Suggested change
In versions 8.9 and above, an {agent} upgrade may fail when the upgrader can't access a PGP key required to verify the binary signature. For details and a workaround, refer to the link:https://www.elastic.co/guide/en/fleet/current/release-notes-8.9.0.html#known-issue-3375[PGP key download fails in an air-gapped environment] known issue in the version 8.9.0 Release Notes or to the link:https://github.com/elastic/elastic-agent/blob/main/docs/pgp-workaround.md[workaround documentation] in the elastic-agent GitHub repository.
In versions 8.9 and above, an {agent} upgrade may fail when the upgrader can't access a PGP key required to verify the binary signature. For details and a workaround, refer to the {fleet-guide}/release-notes-8.9.0.html#known-issue-3375[PGP key download fails in an air-gapped environment] known issue in the version 8.9.0 Release Notes or to the link:https://github.com/elastic/elastic-agent/blob/main/docs/pgp-workaround.md[workaround documentation] in the elastic-agent GitHub repository.

Copy link
Contributor Author

@kilfoyle kilfoyle Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrodewig {fleet-guuide} contains the {branch} attribute, but this particular link will work only in the 8.9 docs, since the 8.9 release notes aren't present in 8.10 or later. So I don't think we can use that attribute here, but I do see that I need to change current to 8.9. :-)

@kilfoyle kilfoyle merged commit df9864f into elastic:main Sep 11, 2023
1 check passed
mergify bot pushed a commit that referenced this pull request Sep 11, 2023
)

* Fix breaking link in 8.10 troubleshooting docs to known issue 3375

* Change link from 'current' to '8.9'

(cherry picked from commit df9864f)
kilfoyle added a commit that referenced this pull request Sep 11, 2023
) (#476)

* Fix breaking link in 8.10 troubleshooting docs to known issue 3375

* Change link from 'current' to '8.9'

(cherry picked from commit df9864f)

Co-authored-by: David Kilfoyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants