[CI] Pull requests migration to buildkite #3573

pazone · 2023-10-09T20:49:31Z

What does this PR do?

Migrates pull request workflow from Jenkins and Github Actions to Buildkite

Migration of Jenkins jobs to new ephemeral VMs:

Ubuntu
Windows
macOS (orka)

Now the pipeline runs build and unit tests on all supported OS in buildkike.
Code coverage files are being downloaded by the merge-coverage. Due to platform dependent code we merge coverage results from all platforms and publish the merged coverage report to sonarQube.

Relates https://github.com/elastic/ingest-dev/issues/1710

mergify · 2023-10-09T20:50:07Z

This pull request does not have a backport label. Could you fix it @pazone? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

elasticmachine · 2023-10-09T21:15:10Z

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-10-30T13:50:36.143+0000
Duration: 3 min 49 sec

Steps errors

Expand to view the steps failures

`Error signal`

Took 0 min 0 sec . View more details here
Description: tar: step failed with error null

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages.
run integration tests : Run the Elastic Agent Integration tests.
run end-to-end tests : Generate the packages and run the E2E Tests.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2023-10-09T21:15:19Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	98.81% (`83/84`)	👍
Files	66.997% (`203/303`)	👍
Classes	65.946% (`366/555`)	👍
Methods	53.241% (`1158/2175`)	👍
Lines	39.578% (`13634/34448`)	👎 -0.02
Conditionals	100.0% (`0/0`)	💚

dliappis

Thank you for this massive work!
Basically LGTM from me, left some minor comments.

Is https://buildkite.com/elastic/elastic-agent/builds/4389 an example run where we can see this work in operation?

dliappis · 2023-10-27T06:49:06Z

.buildkite/scripts/steps/unit-tests.ps1

@@ -0,0 +1,27 @@
+$ErrorActionPreference = "Stop"
+
+Write-Host "-- Fixing CRLF in git checkout --"


nit: if this is meant to be used for creating a collapsed section in the buildkite output shouldn't it have three dashes --- as per https://buildkite.com/docs/pipelines/managing-log-output#collapsing-output?

.buildkite/hooks/post-checkout.ps1

dliappis · 2023-10-27T08:32:56Z

.buildkite/pipeline.yml

+    agents:
+      image: "golang:1.20.10"
+    depends_on:
+      - unit-tests-2204


Alternatively, all the unit-tests* could live in a different group e.g. called unit-tests and this and following steps in another group e.g. test-reports using `depends_on: "unit-tests"

.buildkite/scripts/steps/merge.sh

michalpristas

from what i can tell it looks good.
thanks for making upgrade more stable

cmacknz · 2023-10-27T20:36:06Z

internal/pkg/agent/application/upgrade/upgrade.go

@@ -386,14 +386,16 @@ func copyDir(l *logger.Logger, from, to string, ignoreErrs bool) error {
 		}
 	}

+	// Try to detect if we are running with SSDs. If we are increase the copy concurrency,
+	// otherwise fall back to the default.
+	copyConcurrency := 1


I changed this a bit, if I merge #3653 before you merge this you'll have a conflict to resolve.

blakerouse

Overall the changes to make this run under buildkite look great. Only issue I see and the reason I am making it a blocker is because the RACE_DETECTOR was not enabled, something that we need to keep enabled when running the unit tests.

.ci/Jenkinsfile

mergify · 2023-10-30T13:48:30Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b buildkite_pull_requests upstream/buildkite_pull_requests
git merge upstream/main
git push upstream buildkite_pull_requests

blakerouse

Thanks for enabling the race detector. Looks good now.

elastic-sonarqube · 2023-10-30T14:18:17Z

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

elasticmachine · 2023-10-30T15:25:26Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-10-30T13:51:36.919+0000
Duration: 94 min 46 sec

Test stats 🧪

Test	Results
Failed	0
Passed	4941
Skipped	57
Total	4998

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages.
run integration tests : Run the Elastic Agent Integration tests.
run end-to-end tests : Generate the packages and run the E2E Tests.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

* buildkite test on Ubuntu * Fixed step ids * fix image family * Use aws from arm64 * try windows post-checkout hook * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * set GOPATH * set GOPATH * set GOPATH * set GOPATH * set GOPATH * Installed GCC * Installed GCC * Installed GCC * Windows 2016 * Propagate exit code on windows * Added GOTMPDIR * Added GOTMPDIR * Merge coverage reports step * Merge coverage reports step * Merge coverage reports step * changed installation path * changed installation path * changed installation path * changed installation path * changed installation path * changed installation path * test * test * merge.sh * Added coverage.out to simplify artifacts download * Fixed artifacts copy * buildite orka integration * fix os name * Add err message to upgrade test * Fix autocrlf for windows * Craig's patch * Complete test pipeline * Complete test pipeline * Remove macos GHA workflow * Fix Processing test results step * fix k8s jenkins step * Removed m1 stage * Enabled race detector for unit tests * Enables race detector for windows (cherry picked from commit bf78cc1) # Conflicts: # .buildkite/pipeline.yml # .buildkite/scripts/common.sh # .buildkite/scripts/steps/unit-tests.sh # .ci/Jenkinsfile

* buildkite test on Ubuntu * Fixed step ids * fix image family * Use aws from arm64 * try windows post-checkout hook * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * set GOPATH * set GOPATH * set GOPATH * set GOPATH * set GOPATH * Installed GCC * Installed GCC * Installed GCC * Windows 2016 * Propagate exit code on windows * Added GOTMPDIR * Added GOTMPDIR * Merge coverage reports step * Merge coverage reports step * Merge coverage reports step * changed installation path * changed installation path * changed installation path * changed installation path * changed installation path * changed installation path * test * test * merge.sh * Added coverage.out to simplify artifacts download * Fixed artifacts copy * buildite orka integration * fix os name * Add err message to upgrade test * Fix autocrlf for windows * Craig's patch * Complete test pipeline * Complete test pipeline * Remove macos GHA workflow * Fix Processing test results step * fix k8s jenkins step * Removed m1 stage * Enabled race detector for unit tests * Enables race detector for windows (cherry picked from commit bf78cc1) # Conflicts: # .buildkite/pipeline.yml # .buildkite/scripts/steps/unit-tests.sh # .ci/Jenkinsfile

* buildkite test on Ubuntu * Fixed step ids * fix image family * Use aws from arm64 * try windows post-checkout hook * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * set GOPATH * set GOPATH * set GOPATH * set GOPATH * set GOPATH * Installed GCC * Installed GCC * Installed GCC * Windows 2016 * Propagate exit code on windows * Added GOTMPDIR * Added GOTMPDIR * Merge coverage reports step * Merge coverage reports step * Merge coverage reports step * changed installation path * changed installation path * changed installation path * changed installation path * changed installation path * changed installation path * test * test * merge.sh * Added coverage.out to simplify artifacts download * Fixed artifacts copy * buildite orka integration * fix os name * Add err message to upgrade test * Fix autocrlf for windows * Craig's patch * Complete test pipeline * Complete test pipeline * Remove macos GHA workflow * Fix Processing test results step * fix k8s jenkins step * Removed m1 stage * Enabled race detector for unit tests * Enables race detector for windows (cherry picked from commit bf78cc1)

* buildkite test on Ubuntu * Fixed step ids * fix image family * Use aws from arm64 * try windows post-checkout hook * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * Windows pre-command hook and unit tests ps * set GOPATH * set GOPATH * set GOPATH * set GOPATH * set GOPATH * Installed GCC * Installed GCC * Installed GCC * Windows 2016 * Propagate exit code on windows * Added GOTMPDIR * Added GOTMPDIR * Merge coverage reports step * Merge coverage reports step * Merge coverage reports step * changed installation path * changed installation path * changed installation path * changed installation path * changed installation path * changed installation path * test * test * merge.sh * Added coverage.out to simplify artifacts download * Fixed artifacts copy * buildite orka integration * fix os name * Add err message to upgrade test * Fix autocrlf for windows * Craig's patch * Complete test pipeline * Complete test pipeline * Remove macos GHA workflow * Fix Processing test results step * fix k8s jenkins step * Removed m1 stage * Enabled race detector for unit tests * Enables race detector for windows (cherry picked from commit bf78cc1) Co-authored-by: Pavel Zorin <[email protected]>

pazone added the enhancement New feature or request label Oct 9, 2023

mergify bot assigned pazone Oct 9, 2023

mergify bot added the backport-skip label Oct 9, 2023

pazone added 24 commits October 18, 2023 01:25

buildkite test on Ubuntu

fba1cd5

Fixed step ids

0b6c3dc

fix image family

6eb573a

Use aws from arm64

31ece98

try windows post-checkout hook

75711d3

Windows pre-command hook and unit tests ps

c33a46d

Windows pre-command hook and unit tests ps

d45138b

Windows pre-command hook and unit tests ps

5d98e25

Windows pre-command hook and unit tests ps

0d9b498

Windows pre-command hook and unit tests ps

59b65bf

Windows pre-command hook and unit tests ps

108a01a

Windows pre-command hook and unit tests ps

d2ac348

Windows pre-command hook and unit tests ps

8c5936c

set GOPATH

4a1c285

set GOPATH

43ebbed

set GOPATH

6032209

set GOPATH

ff83b14

set GOPATH

49fe289

Installed GCC

6e5c49d

Installed GCC

59e0112

Installed GCC

4f8a97e

Windows 2016

aa64a97

Propagate exit code on windows

dcaddb2

Added GOTMPDIR

477422c

pazone requested review from blakerouse, alexsapran and dliappis October 26, 2023 13:50

Removed m1 stage

f8b3127

dliappis reviewed Oct 27, 2023

View reviewed changes

michalpristas approved these changes Oct 27, 2023

View reviewed changes

michalpristas added the skip-changelog label Oct 27, 2023

cmacknz reviewed Oct 27, 2023

View reviewed changes

blakerouse requested changes Oct 30, 2023

View reviewed changes

.ci/Jenkinsfile Show resolved Hide resolved

Enabled race detector for unit tests

ffc3991

pazone added 2 commits October 30, 2023 14:49

Merged

c547d9a

Enables race detector for windows

12a1304

blakerouse approved these changes Oct 30, 2023

View reviewed changes

pazone merged commit bf78cc1 into main Oct 30, 2023
12 of 15 checks passed

pazone deleted the buildkite_pull_requests branch October 30, 2023 14:44

This was referenced Nov 6, 2023

[8.11](backport #3691) ironbank: move to ubi9 #3710

Merged

[8.10](backport #3691) ironbank: move to ubi9 #3709

Closed

pazone added backport-v8.9.0 Automated backport with mergify backport-v8.10.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify labels Nov 7, 2023

mergify bot mentioned this pull request Nov 7, 2023

[8.9](backport #3573) [CI] Pull requests migration to buildkite #3718

Closed

This was referenced Nov 7, 2023

[8.10](backport #3573) [CI] Pull requests migration to buildkite #3719

Closed

[8.11](backport #3573) [CI] Pull requests migration to buildkite #3720

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI] Pull requests migration to buildkite #3573

[CI] Pull requests migration to buildkite #3573

pazone commented Oct 9, 2023 •

edited

Loading

mergify bot commented Oct 9, 2023

elasticmachine commented Oct 9, 2023 •

edited

Loading

Build stats

`Error signal`

elasticmachine commented Oct 9, 2023 •

edited

Loading

dliappis left a comment

dliappis Oct 27, 2023

dliappis Oct 27, 2023

michalpristas left a comment

cmacknz Oct 27, 2023

blakerouse left a comment

mergify bot commented Oct 30, 2023

blakerouse left a comment

elastic-sonarqube bot commented Oct 30, 2023

elasticmachine commented Oct 30, 2023

Build stats

Test stats 🧪

		@@ -0,0 +1,27 @@
		$ErrorActionPreference = "Stop"

		Write-Host "-- Fixing CRLF in git checkout --"

[CI] Pull requests migration to buildkite #3573

[CI] Pull requests migration to buildkite #3573

Conversation

pazone commented Oct 9, 2023 • edited Loading

What does this PR do?

mergify bot commented Oct 9, 2023

elasticmachine commented Oct 9, 2023 • edited Loading

❕ Build Aborted

Build stats

Steps errors

Error signal

🤖 GitHub comments

elasticmachine commented Oct 9, 2023 • edited Loading

🌐 Coverage report

dliappis left a comment

Choose a reason for hiding this comment

dliappis Oct 27, 2023

Choose a reason for hiding this comment

dliappis Oct 27, 2023

Choose a reason for hiding this comment

michalpristas left a comment

Choose a reason for hiding this comment

cmacknz Oct 27, 2023

Choose a reason for hiding this comment

blakerouse left a comment

Choose a reason for hiding this comment

mergify bot commented Oct 30, 2023

blakerouse left a comment

Choose a reason for hiding this comment

elastic-sonarqube bot commented Oct 30, 2023

elasticmachine commented Oct 30, 2023

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

pazone commented Oct 9, 2023 •

edited

Loading

elasticmachine commented Oct 9, 2023 •

edited

Loading

`Error signal`

elasticmachine commented Oct 9, 2023 •

edited

Loading