Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upgrade Watcher][Crash Checker] Consider Agent process as crashed if its PID remains 0 #3166

Merged
merged 24 commits into from
Sep 8, 2023
Merged

[Upgrade Watcher][Crash Checker] Consider Agent process as crashed if its PID remains 0 #3166

merged 24 commits into from
Sep 8, 2023

Commits on Sep 8, 2023

  1. Refactoring: extract helper method

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    bb68213 View commit details
    Browse the repository at this point in the history

  2. Add check for PID remaining 0

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    ae2b738 View commit details
    Browse the repository at this point in the history

  3. Update + add tests

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    076e706 View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    faa42b7 View commit details
    Browse the repository at this point in the history

  5. Add CHANGELOG fragment

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    897cea0 View commit details
    Browse the repository at this point in the history

  6. Better error messages

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    8607ca5 View commit details
    Browse the repository at this point in the history

  7. Bump up Agent version + cause error on start

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    e48e4aa View commit details
    Browse the repository at this point in the history

  8. Better logging for debugging

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    474fb2c View commit details
    Browse the repository at this point in the history

  9. More logging for debugging

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    dc779f5 View commit details
    Browse the repository at this point in the history

  10. Trying secondary restart via service manager

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    55cb464 View commit details
    Browse the repository at this point in the history

  11. Add FIXME comments for testing-only changes

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    ba6cf21 View commit details
    Browse the repository at this point in the history

  12. Fix compile errors

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    5dc167c View commit details
    Browse the repository at this point in the history

  13. Update testing version

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    0bec1dd View commit details
    Browse the repository at this point in the history

  14. Implement restart for upstart service manager

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    f3d0e98 View commit details
    Browse the repository at this point in the history

  15. Include service provider name in error

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    cdd2b7a View commit details
    Browse the repository at this point in the history

  16. Implement restart for sysv and darwin

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    ed0fd09 View commit details
    Browse the repository at this point in the history

  17. Implement Restart for Windows

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    3361360 View commit details
    Browse the repository at this point in the history

  18. Remove all Restart() implementations

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    6a6e56e View commit details
    Browse the repository at this point in the history

  19. Removing extraneous logging statements

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    fb14eb1 View commit details
    Browse the repository at this point in the history

  20. Undo vestigial changes

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    4eaa7f1 View commit details
    Browse the repository at this point in the history

  21. Rename all canc -> cancel

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    11989d9 View commit details
    Browse the repository at this point in the history

  22. Use assert instead of require

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    9dba6e6 View commit details
    Browse the repository at this point in the history

  23. Remove testing changes

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    7a804bb View commit details
    Browse the repository at this point in the history

  24. Use assert instead of require

    @ycombinator
    ycombinator committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    37374d7 View commit details
    Browse the repository at this point in the history