Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable proxy tests while flakiness is addressed. #3164

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Aug 1, 2023

All of the proxy tests are currently flaky and fail regularly, see #3154

Disabling them while we investigate a fix to unblock CI.

@cmacknz cmacknz added Team:Elastic-Agent Label for the Agent team skip-changelog labels Aug 1, 2023
@cmacknz cmacknz self-assigned this Aug 1, 2023
@cmacknz cmacknz requested a review from a team as a code owner August 1, 2023 18:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2023

This pull request does not have a backport label. Could you fix it @cmacknz? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Aug 1, 2023
Copy link
Member

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-01T18:03:42.369+0000

  • Duration: 27 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 6153
Skipped 31
Total 6184

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.718% (77/78) 👍
Files 68.498% (187/273) 👍
Classes 67.258% (341/507) 👍
Methods 53.823% (1070/1988) 👍
Lines 40.03% (12246/30592) 👎 -0.003
Conditionals 100.0% (0/0) 💚

@cmacknz cmacknz merged commit f419a37 into elastic:main Aug 1, 2023
15 checks passed
@cmacknz cmacknz deleted the disable-proxy-enroll-test branch August 1, 2023 18:51
@AndersonQ AndersonQ added backport-v8.9.0 Automated backport with mergify and removed backport-skip labels Aug 8, 2023
mergify bot pushed a commit that referenced this pull request Aug 8, 2023
All of the proxy tests are currently flaky and fail regularly, see
#3154

Disabling them while we investigate a fix to unblock CI.

(cherry picked from commit f419a37)

# Conflicts:
#	testing/integration/proxy_url_test.go
AndersonQ pushed a commit to AndersonQ/elastic-agent that referenced this pull request Aug 10, 2023
AndersonQ pushed a commit that referenced this pull request Aug 16, 2023
All of the proxy tests are currently flaky and fail regularly, see
#3154

Disabling them while we investigate a fix to unblock CI.
AndersonQ added a commit that referenced this pull request Aug 16, 2023
…roxy-url integration test and disable tests (#3147)

* enhance mock fleet-server and add --proxy-url integration test  (#2834)

* enhance test fleet-server
Now a almost fully functional mock fleet-server can be instantiated with a single call to fleetservertest.NewServerWithHandlers. The only missing handlers are the upload handlers.
testing/integration/proxy_url_test.go works as example on how to use the new features of  the test fleet-server

* add proxytest.Proxy:
A naive proxy to be used on tests which allows to configure URL rewrites and check all the calls made to it.
check the tests on testing/integration/proxy_url_test.go to see how to use proxytest.Proxy.

* add integration tests for the fleet-server proxy
The tests cover defining a proxy through --proxy-url and in the policy and the correct priority is respected

* fix the Go version used on the Github workflows
now it reads the version from the .go-version and not from the go.mod anymore.

* increase the memory allocated to the elastic-agent vagrant box

* allow -SNAPHOT versions to be passed to define.NewFixture

* add more helper methods to testing.Fixture and Install accepts more flags

* add version.Agent, a exported constant with the agent version

(cherry picked from commit 732d7c0)

* Disable proxy tests while flakiness is addressed. (#3164)

All of the proxy tests are currently flaky and fail regularly, see
#3154

Disabling them while we investigate a fix to unblock CI.

(cherry picked from commit 08d24b9)
---------

Co-authored-by: Anderson Queiroz <[email protected]>
Co-authored-by: Craig MacKenzie <[email protected]>
@rdner rdner added the skipped-test This change disables one or multiple tests label Jan 25, 2024
@rdner
Copy link
Member

rdner commented Feb 25, 2024

Unskipped by #4321

@rdner rdner removed the skipped-test This change disables one or multiple tests label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.9.0 Automated backport with mergify skip-changelog Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants