Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.9](backport #3111) Fix data race in TestActionUnenrollHandler test #3113

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 20, 2023

This is an automatic backport of pull request #3111 done by Mergify.
Cherry-pick of 2a3dfaa has failed:

On branch mergify/bp/8.9/pr-3111
Your branch is up to date with 'origin/8.9'.

You are currently cherry-picking commit 2a3dfaa4fd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   internal/pkg/agent/application/actions/handlers/handler_action_unenroll_test.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested a review from a team as a code owner July 20, 2023 19:29
@mergify mergify bot removed the request for review from a team July 20, 2023 19:29
@mergify mergify bot added the backport label Jul 20, 2023
@mergify mergify bot requested a review from michalpristas July 20, 2023 19:29
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label Jul 20, 2023
@mergify mergify bot requested a review from pchila July 20, 2023 19:29
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 20, 2023

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-14T15:34:08.365+0000

  • Duration: 5 min 24 sec

Steps errors 1

Expand to view the steps failures

check
  • Took 1 min 0 sec . View more details here
  • Description: make check-ci

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor Author

mergify bot commented Jul 24, 2023

This pull request has not been merged yet. Could you please review and merge it @ycombinator? 🙏

1 similar comment
@mergify
Copy link
Contributor Author

mergify bot commented Jul 31, 2023

This pull request has not been merged yet. Could you please review and merge it @ycombinator? 🙏

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Jul 31, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@mergify
Copy link
Contributor Author

mergify bot commented Aug 7, 2023

This pull request has not been merged yet. Could you please review and merge it @ycombinator? 🙏

1 similar comment
@mergify
Copy link
Contributor Author

mergify bot commented Aug 14, 2023

This pull request has not been merged yet. Could you please review and merge it @ycombinator? 🙏

(cherry picked from commit 2a3dfaa)

# Conflicts:
#	internal/pkg/agent/application/actions/handlers/handler_action_unenroll_test.go
@ycombinator
Copy link
Contributor

This change cannot be backported because the file that the change is being applied to, internal/pkg/agent/application/actions/handlers/handler_action_unenroll_test.go, doesn't exist in 8.9.

@ycombinator ycombinator deleted the mergify/bp/8.9/pr-3111 branch August 14, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants