Remove z-index for edit button to prepare for incoming nav refactor #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbarrierwilson
requested review from
glitteringkatie,
colleenmcginnis and
kilfoyle
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
glitteringkatie
approved these changes
Apr 1, 2024
|
Hey @johnbarrierwilson. Thanks for the PR. Can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a new navigation refactor coming in. Despite setting the z-index for the dropdowns in the new navigation to larger than 1000 (as seen in this PR), the browsers still didn't respect the enforcement. This is also a better long term way as the z-index isn't necessary on this element. In addition, the main bug here is that
opacity: 0.3created a new stacking order that broke any z-index declarations.