Ensure more unique grouping key when parsed stack trace is not available. #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble. OpenTelemetry today just sends a tree of `exception.message` and `exception.type` The current logic for `haveExceptionStackTrace` determines there is a stack trace if there is an exception tree. This PR ensures that when an exception tree has no stacktrace anywhere in the tree we include `exception.message` into the hash so that we don't just hash over `exception.type`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenTelemetry today just sends a tree of
exception.messageandexception.typeThe current logic for
haveExceptionStackTracedetermines there is a stack trace if there is an exception tree.This PR ensures that when an exception tree has no stacktrace anywhere in the tree we include
exception.messageinto the hash so that we don't just hash overexception.type.This PR also fixes if we only receive stack trace as string we atleast hash over that instead.