test: fix two issues running tests locally #4220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two issues with testing locally on my dev laptop: 1. `docker-compose` (i.e. Docker Compose v1) is dead and, in some versions, now gone. Time for `docker compose ...` (i.e. v2): https://docs.docker.com/compose/migrate/ ``` % npm test > [email protected] test > ./test/script/run_tests.sh ./test/script/run_tests.sh: line 93: docker-compose: command not found ``` 2. The mysql image has no layer for ARM, i.e. that natively runs on Apple Silicon. ``` % npm test > [email protected] test > ./test/script/run_tests.sh [+] Running 0/1 ⠼ mysql Pulling 1.4s no matching manifest for linux/arm64/v8 in the manifest list entries ```
david-luna
approved these changes
Sep 5, 2024
trentm
deleted the
trentm/fix-local-test-on-amd-and-docker-compose-v2
branch
david-luna
pushed a commit
that referenced
this pull request
Oct 8, 2024
Two issues with testing locally on my dev laptop: 1. `docker-compose` (i.e. Docker Compose v1) is dead and, in some versions, now gone. Time for `docker compose ...` (i.e. v2): https://docs.docker.com/compose/migrate/ ``` % npm test > [email protected] test > ./test/script/run_tests.sh ./test/script/run_tests.sh: line 93: docker-compose: command not found ``` 2. The mysql image has no layer for ARM, i.e. that natively runs on Apple Silicon. ``` % npm test > [email protected] test > ./test/script/run_tests.sh [+] Running 0/1 ⠼ mysql Pulling 1.4s no matching manifest for linux/arm64/v8 in the manifest list entries ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues with testing locally on my dev laptop:
docker-compose(i.e. Docker Compose v1) is dead and, in some versions, now gone. Time fordocker compose ...(i.e. v2): https://docs.docker.com/compose/migrate/